Handle app receipt expirations properly#3
Open
megastep wants to merge 3 commits intormaddy:masterfrom
Open
Conversation
- Convert date strings to NSDate objects where possible. - Ignore empty fields altogether. - Check if the app receipt is past an expiration date in validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my own testing based on this code, I noticed that the Expiration Date field in the app receipt was not being handled at all. This is required if you want to check whether the app receipt has expired (mostly in the context of a Volume Purchase Program).
This pull request fixes this and cleans up a few more things :
NSDateobjects that are easier to access in code.